Eric Blake <ebl...@redhat.com> writes: > On 03/22/2017 12:48 PM, Markus Armbruster wrote: >> From: Eric Blake <ebl...@redhat.com> >> >> An off-by-one in commit 15c2f669e meant that we were failing to >> check for unparsed input in all QemuOpts visitors. Recent testsuite >> additions show that fixing the obvious bug with bogus fields will >> also fix the case of an incomplete list visit; update the tests to >> match the new behavior. >> >> Simple testcase: >> >> ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic -qmp stdio -numa >> node,size=1g >> >> failed to diagnose that 'size' is not a valid argument to -numa, and >> now once again reports: >> >> qemu-system-x86_64: -numa node,size=1g: Invalid parameter 'size' >> >> See also https://bugzilla.redhat.com/show_bug.cgi?id=1434666 >> >> CC: qemu-sta...@nongnu.org >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> Reviewed-by: Michael Roth <mdr...@linux.vnet.ibm.com> >> Tested-by: Laurent Vivier <lviv...@redhat.com> >> Message-Id: <20170322144525.18964-4-ebl...@redhat.com> >> Reviewed-by: Markus Armbruster <arm...@redhat.com> >> [Fixup squashed in] >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > Fixup squashed into the wrong patch. End result is the same, though, so > not sure if it is worth a v3 pull request.
Rats... thanks for paying attention!
