Eric Blake <ebl...@redhat.com> writes:
> On 03/30/2017 08:15 AM, Markus Armbruster wrote:
>> Note that the new variants are impossible in qemu_gluster_glfs_init(),
>> because the gconf->server can only come from qemu_gluster_parse_uri()
>> or qemu_gluster_parse_json(), and neither can create anything but
>> 'inet' or 'unix'.
>>
>> Signed-off-by: Markus Armbruster <arm...@redhat.com>
>> Reviewed-by: Max Reitz <mre...@redhat.com>
>> ---
>> block/gluster.c | 2 ++
>> qapi-schema.json | 19 ++++++++-----------
>> 2 files changed, 10 insertions(+), 11 deletions(-)
>
> Reviewed-by: Eric Blake <ebl...@redhat.com>
>
>
>> -# 2. SocketAddressFlat supports only types 'unix' and 'inet', because
>> -# that's what its current users need.
>> +# This is just like SocketAddress, except it's a flat union rather
>> +# than a simple union. Nicer because it avoids nesting (i.e. more {})
>> +# on the wire.
>
> I know that you are explaining that it is "nesting" which means "more
> {}", but it is SocketAddress that has the extra {}, not
> SocketAddressFlat. I wonder if it reads any better as:
>
> Nicer because it avoids nesting on the wire (i.e. this form has fewer {}).
Sold! (Except I'm peeling off the parenthesis)
