On 03/30/2017 12:28 PM, miny...@acm.org wrote: > From: Corey Minyard <cminy...@mvista.com> > > Macro parameters should almost always have () around them when used. > llvm reported an error on this. > > Remove redundant parenthesis and put parenthesis around the entire > macros with assignments in case they are used in an expression. > > Remove some unused macros. > > Reported in https://bugs.launchpad.net/bugs/1651167 > > Signed-off-by: Corey Minyard <cminy...@mvista.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > --- > hw/ipmi/isa_ipmi_bt.c | 34 ++++++++++++---------------------- > 1 file changed, 12 insertions(+), 22 deletions(-)
Already reviewed by me, so now I'm just adding commentary: Is this still 2.9 material? It silences a build warning under clang, although I didn't analyze whether the unpatched code actually caused an observable behavior bug or just compiler noise. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
