On Fri, Mar 31, 2017 at 03:31:11PM +0100, Peter Maydell wrote: > Commit 001ebaca7b11 fixed some unintended sign extension issues > spotted by Coverity (CID 1005402, 1005403), but didn't catch > all of them. Fix the rest, so we behave consistently whether > 'long' is 32 bit or 64 bit.
Thanks! Reviewed-by: Edgar E. Iglesias <edgar.igles...@xilinx.com> > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > disas/cris.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/disas/cris.c b/disas/cris.c > index 30217f1..2dd56de 100644 > --- a/disas/cris.c > +++ b/disas/cris.c > @@ -2048,7 +2048,7 @@ print_with_operands (const struct cris_opcode *opcodep, > { > /* We're looking at [pc+], i.e. we need to output an immediate > number, where the size can depend on different things. */ > - long number; > + int32_t number; > int signedp > = ((*cs == 'z' && (insn & 0x20)) > || opcodep->match == BDAP_QUICK_OPCODE); > @@ -2290,7 +2290,7 @@ print_with_operands (const struct cris_opcode *opcodep, > > if ((prefix_insn & 0x400) && (prefix_insn & 15) == 15) > { > - long number; > + int32_t number; > unsigned int nbytes; > > /* It's a value. Get its size. */ > -- > 2.7.4 >