On Tue, Apr 11, 2017 at 12:33:49PM +0200, Alberto Garcia wrote: > On Wed 05 Apr 2017 05:11:46 PM CEST, Stefan Hajnoczi <stefa...@redhat.com> > wrote: > > + QemuOptsList *create_opts = NULL; > > + bool image_opts = false; > > + uint64_t img_size = ~0ULL; > > Any reason to use ~0ULL instead of UINT64_MAX ?
Will fix, UINT64_MAX is nicer to read.
> > --- a/qemu-img.texi
> > +++ b/qemu-img.texi
> > @@ -429,6 +429,31 @@ preallocated.
> > For more information, consult @file{include/block/block.h} in QEMU's
> > source code.
> >
> > +@item measure [--output=@var{ofmt}] [-O @var{output_fmt}] [-o
> > @var{options}] [--size @var{N} | [--object @var{objectdef}] [--image-opts]
> > [-f @var{fmt}] [-l @var{snapshot_param}] @var{filename}]
> > +
> > +Calculate the file size required for a new image. This information can be
> > used
> > +to size logical volumes or SAN LUNs appropriately for the image that will
> > be
> > +placed in them. The values reported are guaranteed to be large enough to
> > fit
> > +the image.
>
> It's already explained for other commands, but don't you want to mention
> what ofmt, output_fmt, etc., mean?
Will fix.
signature.asc
Description: PGP signature
