On 04/12/2017 01:40 AM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> Rather than making lots of callers wrap a scalar in a QInt, QString, >> or QBool, provide helper macros that do the wrapping automatically. >> >> Update the Coccinelle script to make mass conversions easy, although >> the conversion itself will be done as a separate patches to ease >> review and backport efforts. >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> >> --- >> v4: tweak comment wording >> v3: new patch >> --- >> include/qapi/qmp/qdict.h | 8 ++++++++ >> include/qapi/qmp/qlist.h | 8 ++++++++ >> scripts/coccinelle/qobject.cocci | 22 ++++++++++++++++++++++ >> 3 files changed, 38 insertions(+) >> >> diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h >> index fe9a4c5..f70d435 100644 >> --- a/include/qapi/qmp/qdict.h >> +++ b/include/qapi/qmp/qdict.h >> @@ -52,6 +52,14 @@ void qdict_destroy_obj(QObject *obj); >> #define qdict_put(qdict, key, obj) \ >> qdict_put_obj(qdict, key, QOBJECT(obj)) >> >> +/* Helpers for int, bool, and string. */ > > Nitpick: this isn't a sentence, so why the period?
Hmm, there's no period on the comment just before: /* Helper to qdict_put_obj(), accepts any object */ I'm fine if you touch it up on commit. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
