On Mon, 17 Apr 2017 18:59:14 -0300 Eduardo Habkost <ehabk...@redhat.com> wrote:
> Every single caller of of pci_register_bus() saves the return value in > phb->bus. Do that inside pci_register_bus() to avoid code duplication > and make it harder to break. > > Most (but not all) conversions done using the following Coccinelle script: > > @@ > identifier b; > expression phb; > @@ > -b = pci_register_bus(phb, ARGS); > +phb->bus = pci_register_bus(phb, ARGS); > ... > -phb->bus = b; > > @@ > expression phb; > expression list ARGS; > @@ > -phb->bus = pci_register_bus(phb, ARGS); > +pci_register_bus(phb, ARGS); > > Cc: Richard Henderson <r...@twiddle.net> > Cc: Aurelien Jarno <aurel...@aurel32.net> > Cc: Yongbok Kim <yongbok....@imgtec.com> > Cc: Alexander Graf <ag...@suse.de> > Cc: Scott Wood <scottw...@freescale.com> > Cc: Paul Burton <paul.bur...@imgtec.com> > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Marcel Apfelbaum <mar...@redhat.com> > Cc: David Gibson <da...@gibson.dropbear.id.au> > Cc: Cornelia Huck <cornelia.h...@de.ibm.com> > Cc: Christian Borntraeger <borntrae...@de.ibm.com> > Cc: qemu-...@nongnu.org > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- > include/hw/pci/pci.h | 12 ++++++------ > hw/alpha/typhoon.c | 10 +++++----- > hw/mips/gt64xxx_pci.c | 9 +++------ > hw/pci-host/apb.c | 7 ++----- > hw/pci-host/bonito.c | 7 +++---- > hw/pci-host/gpex.c | 5 ++--- > hw/pci-host/grackle.c | 9 ++------- > hw/pci-host/ppce500.c | 8 ++++---- > hw/pci-host/uninorth.c | 18 ++++++------------ > hw/pci-host/xilinx-pcie.c | 6 +++--- > hw/pci/pci.c | 14 +++++++------- > hw/ppc/ppc4xx_pci.c | 8 ++++---- > hw/ppc/spapr_pci.c | 10 +++++----- > hw/s390x/s390-pci-bus.c | 10 +++++----- > hw/sh4/sh_pci.c | 9 +++------ > 15 files changed, 60 insertions(+), 82 deletions(-) s390 parts: Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com>
