On 05/08/2017 01:41 PM, Max Reitz wrote: > On 08.05.2017 19:13, Eric Blake wrote: >> When converting a 1.1 image down to 0.10, qemu-iotests 060 forces >> a contrived failure where allocating a cluster used to replace a >> zero cluster reads unaligned data. Since it is a zero cluster >> rather than a data cluster being converted, changing the error >> message to match our earlier change in 'qcow2: Make distinction >> bewteen zero cluster types obvious' is worthwhile. >> >> Suggested-by: Max Reitz <mre...@redhat.com> >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> --- >> >> There's one more instance of "Data cluster offset" in qcow2-cluster.c, >> but that one in handle_copied() is contained inside a >> cluster_type == QCOW2_CLUSTER_NORMAL conditional. >> >> block/qcow2-cluster.c | 3 ++- >> tests/qemu-iotests/060.out | 2 +- >> 2 files changed, 3 insertions(+), 2 deletions(-) > > Looks good, except for one thing: This is for qemu-img amend, not > qemu-img convert. > > I can handle that, if you'd like, though. :-)
So is fixing my commit message considered a conversion, or an amendment? -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
