On 05/17/2017 04:05 PM, John Bradley via Qemu-devel wrote: >>From 0b39a04030d5a2cea4fcd2159d365580ca155b78 Mon Sep 17 00:00:00 2001 > From: John Bradley <fly...@rocketmail.com> > Date: Wed, 17 May 2017 18:57:21 +0100 > Subject: [PATCH] Add BCM2835 devices to Arm hardware. > > Signed-off-by: John Bradley <fly...@rocketmail.com> > --- > hw/arm/bcm2835.c | 114 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 114 insertions(+) >
> +#include "qemu/osdep.h" > +#include "cpu.h" > +#include "hw/arm/bcm2835.h" This file does not exist in master. Since it is obvious that this patch depends on other patches you have pending, you should submit everything as a patch series (where the patch adding bcm2835.h would be labeled 1/2, and this patch labeled 2/2, as well as with a 0/2 cover letter - or 0/N for however many N patches you plan to submit). Posting each dependent patch as a top-level thread with no documentation on how they interrelate is just going to waste reviewer's time, as well as trigger more bot-related compile failure messages to you, that could have been prevented if it had been properly submitted as a series. It looks like you are not using 'git send-email' to send your patches. That makes it highly likely that your patches will be corrupted to the point that they cannot be applied by automated tooling. While a one-off patch submission can usually be manually beaten into correct form by the maintainer, it is much harder to offload this burden onto others when you plan to submit a series - so you should really fix your workflow to get 'git send-email' working properly. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature