On Wed, May 17, 2017 at 05:47:50PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela <quint...@redhat.com> > --- > include/migration/migration.h | 1 + > include/migration/qemu-file.h | 4 ---- > migration/channel.c | 1 + > migration/colo.c | 1 + > migration/migration.c | 1 + > migration/qemu-file-channel.c | 1 + > migration/qemu-file-channel.h | 21 +++++++++++++++++++++ > migration/rdma.c | 1 + > migration/savevm.c | 1 + > tests/test-vmstate.c | 1 + > 10 files changed, 29 insertions(+), 4 deletions(-) > create mode 100644 migration/qemu-file-channel.h > > diff --git a/include/migration/migration.h b/include/migration/migration.h > index e831259..8280df1 100644 > --- a/include/migration/migration.h > +++ b/include/migration/migration.h > @@ -19,6 +19,7 @@ > #include "qemu/thread.h" > #include "qemu/notify.h" > #include "migration/vmstate.h" > +#include "io/channel.h"
Could I ask why we add this line here? I thought one of the main goals of this series is removing things from migration.h... > #include "qapi-types.h" > #include "exec/cpu-common.h" > #include "qemu/coroutine_int.h" Thanks, -- Peter Xu