Markus Armbruster <arm...@redhat.com> writes: > Juan Quintela <quint...@redhat.com> writes: > >> We have change in the previous patch to use migration capabilities for >> it. Notice that we continue using the old command line flags from >> migrate command from the time being. Remove the set_params method as >> now it is empty. >> >> For savevm, one can't do a: >> >> savevm -b/-i foo > > Yes (savem has no such options). > >> but now one can do: >> >> migrate_set_capability block on >> savevm foo >> >> And we can't use block migration. We could disable block capability >> unconditionally, but it would not be much better. > > This leaves me confused: what does the example do? Reading ahead... > looks like it fails with "Block migration and snapshots are > incompatible". What are you trying to say here?
I think I now get what you're trying to say, but only because I've picked up enough context. Let me try to rephrase: migration: Use new configuration instead of old MigrationParams The previous commit introduced a MigrationCapability and a MigrationParameter for block migration. Use them instead of the old MigrationParams. Take care to reject attempts to combine block migration with snapshots, e.g. like this: migrate_set_capability block on savevm foo >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> Reviewed-by: Eric Blake <ebl...@redhat.com> > > Patch looks good to me. Preferably with a commit message I can still understand three weeks from now: Reviewed-by: Markus Armbruster <arm...@redhat.com>