On 05/23/2017 11:10 PM, Philippe Mathieu-Daudé wrote: > Hi Hervé, > > On 05/22/2017 06:11 PM, Hervé Poussineau wrote: >> - offset_to_bootsector is the number of sectors up to FAT bootsector >> - offset_to_fat is the number of sectors up to first File Allocation >> Table >> - offset_to_root_dir is the number of sectors up to root directory sector > > Eventually your commit description can end here, adding the 3 following > lines below the "---" separator.
No. Stuff after the --- is intended for things that are useful to reviewers, but not helpful in the long run. But in this case: > >> Replace first_sectors_number - 1 by offset_to_bootsector. Knowing the conversion that was made DOES make it easier to read this patch, even in the long run. So this information belongs before the ---. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
