On Thu, Jun 01, 2017 at 08:10:27AM +0000, Marc-André Lureau wrote: > Hi > > On Mon, May 29, 2017 at 7:18 PM Ben Warren via Qemu-devel < > qemu-devel@nongnu.org> wrote: > > From: Ben Warren <b...@skyportsystems.com> > > The following tests are implemented: > * test that a GUID passed in by command line is propagated to the guest. > Read the GUID from guest memory > * test that the "auto" argument to the GUID generates a valid GUID, as > seen by the guest. > * test that a GUID passed in can be queried from the monitor > > This patch is loosely based on a previous patch from: > Gal Hammer <gham...@redhat.com> and Igor Mammedov <imamm...@redhat.com> > > Signed-off-by: Ben Warren <b...@skyportsystems.com> > Reviewed-by: Igor Mammedov <imamm...@redhat.com> > ---
What happened to indentation here? > + * in order to implement the "OVMF SDT Header probe > suppressor" > + * see docs/specs/vmgenid.txt for more details > + */ > + return vgid_table.vgia_val + VMGENID_GUID_OFFSET; > + } > > > It leaks tables > > Other than that: > Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> Ben, are you going to post a version that doesn't leak?
