On Thu, Jun 01, 2017 at 10:37:39AM -0500, Michael Roth wrote: > Quoting David Gibson (2017-05-31 20:52:17) > > DRConnectorClass has a set_configured method, however: > > * There is only one implementation, and only ever likely to be one > > * There's exactly one caller, and that's (now) local > > * The implementation is very straightforward > > > > So abolish the method entirely, and just open-code what we need. We also > > remove the tracepoints associated with it, since they don't look to be > > terribly useful. > > Dropping the method makes sense, but the 'configured' state affects a > lot of the state-transitions throughout the code so I think it may > be useful to keep the traces.
Fair point, I'll put the traces back in.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
