On 06/08/2017 04:32 PM, Greg Kurz wrote: > On Thu, 8 Jun 2017 16:04:21 +0200 > Cédric Le Goater <c...@kaod.org> wrote: > >> On 06/08/2017 03:42 PM, Greg Kurz wrote: >>> These properties are part of the XICS API. They deserve to appear >>> explicitely in the XICS header file. >> >> I don't see the benefits. >> > > The links need to be set with the appropriate name otherwise XICS bails out. > When David asked to rename the "cs" prop to "cpu",
yes. that is better. > I forgot to patch pnv accordingly in the first place. :) > > FWIW, other people do that as well (see hw/i386/pc_q35.c for example). well, I don't see the benefits of changing a string constant by a define. Cheers, C.
