On Tue, Jun 13, 2017 at 11:52:41PM -0700, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH qemu v8 0/2] memory/iommu: QOM'fy IOMMU > MemoryRegion > Message-id: 20170614063607.47863-1-...@ozlabs.ru > Type: series > > === TEST SCRIPT BEGIN === > #!/bin/bash > > BASE=base > n=1 > total=$(git log --oneline $BASE.. | wc -l) > failed=0 > > git config --local diff.renamelimit 0 > git config --local diff.renames True > > commits="$(git log --format=%H --reverse $BASE..)" > for c in $commits; do > echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." > if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; > then > failed=1 > echo > fi > n=$((n+1)) > done > > exit $failed > === TEST SCRIPT END === > > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > From https://github.com/patchew-project/qemu > - [tag update] patchew/20170613140358.81651-1-vsement...@virtuozzo.com > -> patchew/20170613140358.81651-1-vsement...@virtuozzo.com > * [new tag] patchew/20170614064452.23167-1-sjitindarsi...@gmail.com > -> patchew/20170614064452.23167-1-sjitindarsi...@gmail.com > Switched to a new branch 'test' > 3d08aca memory/iommu: introduce IOMMUMemoryRegionClass > d1443b0 memory/iommu: QOM'fy IOMMU MemoryRegion > > === OUTPUT BEGIN === > Checking PATCH 1/2: memory/iommu: QOM'fy IOMMU MemoryRegion... > ERROR: spaces required around that '*' (ctx:WxO) > #129: FILE: hw/dma/rc4030.c:720: > +DeviceState *rc4030_init(rc4030_dma **dmas, IOMMUMemoryRegion **dma_mr) > ^
False positive. checkpatch thinks this is a multiplicatin rather
thana pointer designation.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
