After previous patch to let qdev_prop_register_global_list() use register_compat_prop(), then caller won't be guaranteed that the GlobalProperty pointer passed in will be the one linked to global_props list (now we always alloc new GlobalProperty for it). So prop->used will never be set.
Let's avoid checking this in test codes to make the test pass. Signed-off-by: Peter Xu <pet...@redhat.com> --- tests/test-qdev-global-props.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-props.c index 48e5b73..599bb13 100644 --- a/tests/test-qdev-global-props.c +++ b/tests/test-qdev-global-props.c @@ -218,12 +218,6 @@ static void test_dynamic_globalprop_subprocess(void) g_assert_cmpuint(mt->prop2, ==, 102); all_used = qdev_prop_check_globals(); g_assert_cmpuint(all_used, ==, 1); - g_assert(props[0].used); - g_assert(props[1].used); - g_assert(!props[2].used); - g_assert(!props[3].used); - g_assert(!props[4].used); - g_assert(!props[5].used); } static void test_dynamic_globalprop(void) @@ -263,12 +257,6 @@ static void test_dynamic_globalprop_nouser_subprocess(void) g_assert_cmpuint(mt->prop2, ==, 102); all_used = qdev_prop_check_globals(); g_assert_cmpuint(all_used, ==, 0); - g_assert(props[0].used); - g_assert(props[1].used); - g_assert(!props[2].used); - g_assert(!props[3].used); - g_assert(!props[4].used); - g_assert(!props[5].used); } static void test_dynamic_globalprop_nouser(void) -- 2.7.4