On Thu, Jun 22, 2017 at 01:26:49PM +0100, Dr. David Alan Gilbert wrote: > * Eduardo Habkost (ehabk...@redhat.com) wrote: > > Make it possible to set the RAM_NONPERSISTENT flag on the RAMBlock when > > mapping a file. > > > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > > Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > A little confusing having a persistent flag passed in but setting a > NONPERSISTENT flag. > > One thing to watch out for is the other effect, for example I think > doing an MADV_REMOVE will zero the file; if that's a ROM file that > would probably be bad; but your description of persistent=false > might make sense for a ROM file since it wont be changed.
Good point. Sounds like a good idea to reword the documentation to mentiuon that in addition to making data not written back, contents might be destroyed. -- Eduardo
