On 06/26/2017 09:10 PM, Eric Blake wrote: > On 06/16/2017 05:12 AM, Daniel P. Berrange wrote: >> The semantics around handling ipv4=on|off & ipv6=on|off are quite >> subtle to understand in combination with the various hostname addresses >> and backend types. Introduce a massive test matrix that launches QEMU >> and validates the ability to connect a client on each protocol as >> appropriate. >> >> The test requires that the host has ability to bind to both :: and >> 0.0.0.0, on port 9000. If either protocol is not available, or if >> something is already listening on that port the test will skip. >> >> Although it isn't using the QTest APIs, it expects the >> QTEST_QEMU_BINARY env variable to be set. > > I note that on failure, v3 created test-sockets-proto.pid in the current > working directory (the top level, if I ran 'make check-qtest') rather > than under the tests/ subdirectory or even better under a scratch > location that gets automatically cleaned up regardless of failure mode. > > Since v3 failed for me, but v4 passes (and cleans up on success), I > can't say if that is still a problem in v4.
Scratch that - I just confirmed that 'test-sockets-proto.pid' is still created and now listed by 'git status' as a stray file after my in-tree build 'make check', even though the test passed. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
