On 06/15/2017 11:38 AM, Stefan Hajnoczi wrote: > Avoid duplicating the QEMU command-line. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > tests/qemu-iotests/068 | 13 ++++++++----- > 1 file changed, 8 insertions(+), 5 deletions(-) >
> +# Give qemu some time to boot before saving the VM state > +bash -c 'sleep 1; echo -e "savevm 0\nquit"' | _qemu Are we sure that 'bash' on PATH is the same as the /bin/bash running the script? Also, while bash has more deterministic behavior for 'echo -e' (it is non-portable if you are porting a script to other shells), it is still possible to set bash to a mode where it does not work (see xhopt xpg_echo). I'd much prefer you use 'printf' instead of 'set -e'. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
