On Wed, Jun 28, 2017 at 2:04 AM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Tue, Jun 27, 2017 at 01:45:45PM -0700, Alistair Francis wrote: >> Add a functino which can be used similarly to error_report() execpt to >> inform the users about warnings instead of errors. >> >> The warning print does not include the timestamp and instead will >> preface the messages with a 'warning: '. > > Not including the timestamp is a bug IMHO. If I've turned on timestamps, > I expect all messages to have the timestamp.
That's fine, I'm happy to add it back in. I just wasn't sure. > > I'm not particularly convinced by adding the 'warning: ' prefix either, > particularly given the scenario you are using this in, is not actually > a warning - its just a informative message. Maybe it makes more sense to add an extra argument to error_report() that can be used to specify error, warning or information. The same way qemu_log_mask() works. That was Edgar's idea in reply to one of the other patches. Does that sound more useful? Thanks, Alistair > > > Regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
