On Thu, Jun 29, 2017 at 03:23:04PM +0200, Marc-André Lureau wrote: > This compat property sole function is to prevent the device from being > instantiated. Instead of requiring an extra compat property, check if > fw_cfg has DMA enabled. > > This has the additional benefit of handling other cases properly, like: > > $ qemu-system-x86_64 -device vmgenid -machine none > qemu-system-x86_64: -device vmgenid: vmgenid requires DMA write support in > fw_cfg, which this machine type does not provide > $ qemu-system-x86_64 -device vmgenid -machine pc-i440fx-2.9 -global > fw_cfg.dma_enabled=off > qemu-system-x86_64: -device vmgenid: vmgenid requires DMA write support in > fw_cfg, which this machine type does not provide > $ qemu-system-x86_64 -device vmgenid -machine pc-i440fx-2.6 -global > fw_cfg.dma_enabled=on > [boots normally] > > Suggested-by: Eduardo Habkost <ehabk...@redhat.com> > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
Reviewed-by: Eduardo Habkost <ehabk...@redhat.com> -- Eduardo
