Re: [Qemu-devel] [PATCH v2 2/8] target/s390x: Implement CONVERT UNICODE insns

[Richard Henderson]

On 07/02/2017 06:18 AM, Aurelien Jarno wrote:

+    if (!s390_has_feat(s->insn->fac == S390_FEAT_EXTENDED_TRANSLATION_3
+                       ? S390_FEAT_ETF3_ENH : S390_FEAT_ETF2_ENH)) {
+        m3 = 0;
+    }

This doesn't look correct to me. The well-formedness checking is part of
ETF3_ENH facility, for both convert unicode instructions that are part
of the Z architecture (CU12 and CU21) and for the ones added by the ETF3
facility (CU14 and CU24).

Quite right.


r~