On 04/07/2017 10:32, Daniel P. Berrange wrote:
>> if test -z "${target_list+xxx}" ; then
>> - target_list="$default_target_list"
>> + for target in $default_target_list; do
>> + supported_target $target 2>/dev/null && \
>> + target_list="$target_list $target"
>> + done
>
> I'm not sure what the benefit of this change is ? It is calling
> supported_target but throwing away anything it prints. So if there
> was a mistake in the default target list setup, we'd never see it,
> just silently discard it.
As of this patch there is no benefit, but it is what makes patch 3 drop
non-hardware-accelerated targets for --disable-tcg.
Paolo
