On 04.07.2017 14:27, Daniel P. Berrange wrote: > On Tue, Jul 04, 2017 at 02:21:28PM +0200, Thomas Huth wrote: >> On 04.07.2017 13:14, Daniel P. Berrange wrote: >> [...] >>> - Not listing the '-6' and '-e' args to qemu-img create. Those >>> were never deprecations, because the functionality was >>> immediately turned into a fatal error. >> How did you come to that conclusion? As far as I can see, the -6 option >> has been added by commit ec36ba14748e140dda2 and that was part of QEMU >> v0.10. The deprecation was done in commit eec77d9e712bd415 and that was >> part of QEMU v0.14. > > A 'deprecation' message implies that the functionality continues to > work, but the user gets a warning that its going away. In this case > the user gets a warning, and the functionality is unusable - qemu-img > just exits immediately. This isn't deprecation in any normal sense, > it is just immediate feature removal with an message telling you it > has already been deleted :-(
Ah, right, of course ... I somehow read your original sentence that the functionality would have been added in one release cycle and also removed again in the same cycle, that's why I was confused, but it makes sense now. So yes, should be fine to remove this code immediately now. Thomas
