On 07/04/2017 06:59 PM, Cornelia Huck wrote:
> On Tue, 4 Jul 2017 17:08:52 +0200
> Halil Pasic <pa...@linux.vnet.ibm.com> wrote:
>
>>>>> cd.type = KVM_DEV_TYPE_FLIC;
>>>>> ret = kvm_vm_ioctl(kvm_state, KVM_CREATE_DEVICE, &cd);
>>>>> if (ret < 0) {
>>>>> - trace_flic_create_device(errno);
>>>>> - return;
>>>>> + error_setg_errno(&errp_local, errno, "Creating the KVM device
>>>>> failed");
>>>>> + trace_flic_no_device_api(errno);
>>>>
>>>> Err... this should still be trace_flic_create_device(), no?
>>>
>>> I'm afraid you are right! Probably a copy paste error :/
>>>
>>
>> Do you think the traces are still appropriate once we have
>> proper error propagation?
>
> They add less value, but I'd just keep them.
>
>>
>> I did not feel comfortable removing them but thinking again,
>> than might be the thing to do.
>>
>> @Christian:
>> I think we should really fix this the one way or the other.
>> Can you tell me what is the proper procedure?
>
> I'd vote for just fixing the trace event. Smaller change, and we can
> revisit this later.
>
+1
