Marc-André Lureau <marcandre.lur...@redhat.com> writes: > Hi, > > After investigating a bit using clang-tidy to do some coroutine checks > (and hitting a wall as there are no pre-processor info in the AST), it > was suggested to me on the clang mailing list to try to use > -Wthread-safety. I had to modify clang a bit to make it work on qemu > code base (annotations on function typedef etc, > https://github.com/elmarco/clang qemu-ta branch - very hackish state).
Hardcore! Are your clang modifications upstreamable once cleaned up? > The analysis simply checks that coroutine_fn are called from a > coroutine "context" (or "role"). I couldn't find any misuse in qemu > code base, however, a number of coroutine_fn annotations are missing. > > (I think it would make sense to squash all the "mark coroutine_fn" > commits if we apply them, I tried to split them by domains/maintainer > to ease review) [...] > 49 files changed, 299 insertions(+), 132 deletions(-) "A number of coroutine_fn annotations are missing" seems to be an understatement :)
