On 11 July 2017 at 16:07, Ben Warren <b...@skyportsystems.com> wrote: > Hi Peter, >> On Jul 11, 2017, at 6:32 AM, Peter Maydell <peter.mayd...@linaro.org> wrote: >> >> On 3 July 2017 at 20:45, Michael S. Tsirkin <m...@redhat.com> wrote: >>> From: Ben Warren <b...@skyportsystems.com> >>> >>> The following tests are implemented: >>> * test that a GUID passed in by command line is propagated to the guest. >>> Read the GUID from guest memory >>> * test that the "auto" argument to the GUID generates a valid GUID, as >>> seen by the guest. >>> * test that a GUID passed in can be queried from the monitor >>> >>> This patch is loosely based on a previous patch from: >>> Gal Hammer <gham...@redhat.com> and Igor Mammedov <imamm...@redhat.com> >>> >>> Signed-off-by: Ben Warren <b...@skyportsystems.com> >>> Reviewed-by: Igor Mammedov <imamm...@redhat.com> >>> Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> >>> Reviewed-by: Michael S. Tsirkin <m...@redhat.com> >>> Signed-off-by: Michael S. Tsirkin <m...@redhat.com> >> >> Hi -- this test seems to intermittently fail: >> >> TEST: tests/vmgenid-test... (pid=15466) >> /i386/vmgenid/vmgenid/set-guid: ** >> ERROR:/home/peter.maydell/qemu/tests/vmgenid-test.c:65:acpi_find_vgia: >> assertion failed (ACPI_ASSERT_CMP >> _str == "RSDT"): ("" == "RSDT") >> FAIL >> GTester: last random seed: R02S27021da892f2124a377287729b848ff8 >> (pid=15470) >> /i386/vmgenid/vmgenid/set-guid-auto: OK >> /i386/vmgenid/vmgenid/query-monitor: OK >> FAIL: tests/vmgenid-test >> >> (that's an aarch32 build). >> >> > I’ll try to reproduce. How exactly are the tests called?
'make check V=1', same as usual. I did a manual run of just this test, with while QTEST_QEMU_BINARY=i386-softmmu/qemu-system-i386 gtester -k --verbose -m=quick tests/vmgenid-test ;do true ;done but that didn't seem to fall over, so either the test is very intermittently flaky, or it depends on load on the machine or something. thanks -- PMM