On 11.07.2017 16:23, Cornelia Huck wrote: > On Tue, 11 Jul 2017 15:56:33 +0200 > Thomas Huth <th...@redhat.com> wrote: > >> The upcoming virtio-net driver needs to negotiate some features, >> so we need the possibility to do this in the core virtio code. >> >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >> pc-bios/s390-ccw/s390-ccw.h | 2 ++ >> pc-bios/s390-ccw/virtio.c | 23 +++++++++++++++++------ >> pc-bios/s390-ccw/virtio.h | 1 + >> 3 files changed, 20 insertions(+), 6 deletions(-) > > >> diff --git a/pc-bios/s390-ccw/virtio.h b/pc-bios/s390-ccw/virtio.h >> index d733780..a00a320 100644 >> --- a/pc-bios/s390-ccw/virtio.h >> +++ b/pc-bios/s390-ccw/virtio.h >> @@ -251,6 +251,7 @@ struct VDev { >> ScsiDevice selected_scsi_device; >> uint64_t netboot_start_addr; >> uint32_t max_transfer; >> + uint32_t guest_features[2]; > > Just 'features' might have been a better name, but:
I think it's clearer to call it guest_features ... in case we ever want to store the host features, too. >> }; >> typedef struct VDev VDev; >> > > Reviewed-by: Cornelia Huck <coh...@redhat.com> Thanks! Thomas