On 07/20/2017 09:20 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven <p...@kamp.de> > --- > block/qcow2.c | 9 +++++++++ > qapi/block-core.json | 6 +++++- > 2 files changed, 14 insertions(+), 1 deletion(-) >
> diff --git a/qapi/block-core.json b/qapi/block-core.json > index 9eb76df..9310715 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -68,6 +68,9 @@ > # @encrypt: details about encryption parameters; only set if image > # is encrypted (since 2.10) > # > +# @compress: details about parameters for compressed clusters; only set if > +# the compress format header extension is present (since 2.10) Would it be possible/wise to ALWAYS output compression information, even if it is the older style zlib with small window and default level? Made easier if you can represent all tunables of zlib (where you special-case writing the qcow2 header to omit the extension header when the user has requested the defaults). This is a new feature, and unfortunately we've missed soft freeze for 2.10. You'll want to update your series to uniformly state since 2.11. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
