On 07/25/2017 03:24 AM, Lluís Vilanova wrote: > Eric Blake writes: > >> On 07/24/2017 12:46 PM, Lluís Vilanova wrote: >>> Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu> >>> --- >>> instrument/Makefile.objs | 1 + >>> instrument/qmp.c | 71 ++++++++++++++++++++++++++++++++++++ >>> qapi-schema.json | 3 ++ >>> qapi/instrument.json | 92 >>> ++++++++++++++++++++++++++++++++++++++++++++++ >>> 4 files changed, 167 insertions(+) >>> create mode 100644 instrument/qmp.c >>> create mode 100644 qapi/instrument.json > >> Adding new files; but I don't see a patch to MAINTAINERS to cover >> instrument/*. > > Who should I put as a maintainer? Or does this go to the general > maintainer(s)?
You can be the maintainer if you'd like; or see if Stefan is okay
including it as part of the trace files, since it trace-related.
>>> +##
>>> +{ 'command': 'instr-load',
>>> + 'data': { 'path': 'str', '*args': ['String'] },
>
>> Why are you double-nesting things? It's a lot nicer to use ['str']
> Aha, you mean the definition should be this instead?
>
> { 'command': 'instr-load',
> 'data': { 'path': 'str', '*args': ['str'] },
> 'returns': 'InstrLoadResult' }
Yes.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
