On 07/25/2017 10:28 PM, Philippe Mathieu-Daudé wrote:
>>> - rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga TAGS
>>> cscope.* *.pod *~ */*~
>>> + rm -f $(filter-out %.tlb,$(TOOLS)) $(HELPERS-y) qemu-ga${EXESUF}
>>> TAGS cscope.* *.pod *~ */*~
>>>
>>> It's a bit ugly since `rm -f qemu-ga.exe` would silently fail on posix,But that's the whole point of 'rm -f' - to silently ignore files that didn't exist. >> >> On w32 I mean, sorry. > > side question: should we use $(RM) with something like: > > ifeq ($(OS),Windows_NT) > RM = cmd //C del //Q //F > else > RM = rf -f > endif > Absolutely not. We can at least assume a mingw-like environment that has all the usual tools like rm. >>> >>> Alternatively, you can explicitly check for qemu-ga.exe and remove it if >>> it exists. I would consider either acceptable, but not this patch as it >>> currently stands. But that's what 'rm -f' already does - I don't see the point in adding a racy check for existence prior to deletion, when deletion already handles the race. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
