On Wed, Jul 26, 2017 at 02:33:10PM +0200, Gerd Hoffmann wrote: > Hi, > > > FYI, after adding qcodes to the keycodemapdb, (but not having picked > > your branch), > > I don't think this is a good idea. qkeycode numbers are a qemu-private > thing, they can (and did in the past) change. The names are api and > must not change.
Sorry, yes, I meant only adding the names - libvirt needs to know the qcode names and what they map to in other key maps, to use the send-key command. > > I was actually just going add an entry for QKeyCode names to the > > keycodemapdb, so we can convert straight to that, and also let > > us auto-generate the qemu_input_linux_to_qcode() table. > > Ok, with the names it should work. > > > Strangely there is no Linux key code defined for AltGr, so if we > > map via Linux key codes, we would loose ability to send AltGr > > KEY_RIGHTALT? It seems KEY_RIGHTALT is different from AltGr - it maps to AT set 1 extended scancode 0xe0 0x38, where as AltGr generates 0x64 on my keyboard Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
