On Wed, Jul 26, 2017 at 04:24:41PM -0400, Paolo Bonzini wrote: > > > The point is that for PC we really should not keep piling up hacks, > > compatibility is more important. > > Non-explosion of the test matrix is just as important.
Absolutely. > > > Doing it for PC only would mean switching > > > back from FADT rev3 to rev1, which is worse for guest OS support, > > > > It's only OSX AFAIK and IIRC OSX doesn't run on PC anyway. > > Sure it does. You can run it on VMware Workstation which emulates > some i440FX-like chipset. I don't think it works on our PC though. Never tried, going by Gabriel's word though. > > It's definitely way more code. I'll change my mind if there's > > a guest that needs the new FADT. > > Then you can prepare a patch to revert the FADTv3 commit, or do the > work to make it specific to the 2.10 Q35 machine type. > > Paolo Right, Igor said he's doing that. -- MST
