On Thu, 20 Jul 2017, Stefan Fritsch wrote: > Thanks for the review. > > On Thu, 20 Jul 2017, Marc-André Lureau wrote: > > > On Thu, Jul 20, 2017 at 11:04 AM Stefan Fritsch <s...@sfritsch.de> wrote: > > > > > From: Stefan Fritsch <stefan_frit...@genua.de> > > > > > > Change all DPRINTF()s using (1 == WARN) to use symbolic > > > constants. Most of these DPRINTFs are now only logging at higher log > > > levels. > > > > > > This allows to use ccid's debug level 1 == WARN in normal operation.
> > > case ClassInterfaceRequest | CCID_CONTROL_GET_DATA_RATES: > > > - DPRINTF(s, 1, "ccid_control get data rates UNIMPLEMENTED\n"); > > > + DPRINTF(s, D_INFO, "ccid_control get data rates > > > UNIMPLEMENTED\n"); > > > p->status = USB_RET_STALL; > > > break; > > > > > > > WARN was quite appropriate for unimplemented code reached, no? > > True. I will re-check if these messages are triggered during normal > operation for us. I don't see them even with WARN. I will make all your suggested adjustions in the next version of the patchset. Cheers, Stefan
