On Thu, Jul 27, 2017 at 08:53:48PM +1000, David Gibson wrote: > On Thu, Jul 27, 2017 at 10:11:48AM +0100, Peter Maydell wrote: > > On 27 July 2017 at 02:30, Michael Roth <mdr...@linux.vnet.ibm.com> wrote: > > > In particular, Mellanox CX4 adapters on PowerNV hosts might not be fully > > > quiesced by vfio-pci's finalize() routine until up to 6s after the > > > DEVICE_DELETED was emitted, leading to detach-device on the libvirt side > > > pretty > > > much always crashing the host. > > > > My initial naive thought is that if the host kernel can crash then > > this is a host kernel bug... shouldn't the host kernel refuse > > the subsequent libvirt rebind if it would cause a crash ? > > I think so too, but I haven't been able to convince Alex. Nor > find time to fix it in the kernel myself.
I think we need to fix both the QEMU premature sending of DEVICE_DELETED and the kernel bug that allowed the crash. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|