On Fri, Jul 28, 2017 at 08:21:49AM +0200, Gerd Hoffmann wrote: > On Thu, 2017-07-27 at 18:45 +0100, Daniel P. Berrange wrote: > > On Thu, Jul 27, 2017 at 04:00:22PM +0200, Gerd Hoffmann wrote: > > > Add multimedia keys to QKeyCodes and to the keymaps. > > > > > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > > Message-id: 20170726152918.11995-5-kra...@redhat.com > > > --- > > > ui/input-keymap.c | 44 > > > ++++++++++++++++++++++++++++++++++++++++++++ > > > qapi-schema.json | 28 +++++++++++++++++++++++++++- > > > 2 files changed, 71 insertions(+), 1 deletion(-) > > >
> > I'm curious what the 'AC_' prefix on all these is indicating ? > > Do we actually need it ? > > Seems to stand for "application control". > > # grep " AC " include/standard-headers/linux/input-event-codes.h > * AC - Application Control > #define KEY_STOP 128 /* AC Stop */ > #define KEY_PROPS 130 /* AC Properties */ > #define KEY_UNDO 131 /* AC Undo */ > [ ... ] > > I think it is better to keep it, even if it is inconsistent because we > already have stop + find without prefix. Just dropping the ac_ prefix > will not work for some keys, ac_home for example. Ok > > > Missing Q_KEY_CODE_MEDIASELECT entry - presumably it was supposed > > to map to KEY_MEDIA > > There is KEY_SELECT too, but not KEY_MEDIASELECT. Hmm. I found a keyboard with a key labelled "Media" and when pressed it generates Linux key 171 / AT set1 0xe0 0x01 which is KEY_CONFIG and GNOME pops up the control panel when pressed ! Would be interested to know results of "showkey" and "showkey -s" for any other keyboards with a key labelled "Media", since I don't entirely trust this particular one to be representative of general usage. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
