On Mon, Jul 31, 2017 at 09:44:13AM -0500, Eric Blake wrote: > On 07/31/2017 08:47 AM, Jeff Cody wrote: > > Right now, all qemu-iotests output data into the same scratch directory, > > and so each tests needs to be responsible for cleanup up its own files. > > s/cleanup up/cleaning up/ >
Thanks - I'll send a v3 with that change after a while, in case there are more comments. Or if someone applies it to their branch, they can just fix up the commit message if they want. (Hmm... I guess also s/each tests/each test as well, to be grammatically correct) > > > > Have each test use 'scratch/$seq' as its temp directory, so the check > > script can do simple cleanup of removing the whole temporary directory. > > > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > Signed-off-by: Jeff Cody <jc...@redhat.com> > > --- > > tests/qemu-iotests/check | 21 +++++++++++++++++---- > > 1 file changed, 17 insertions(+), 4 deletions(-) > > R-b stands (thanks for adding the && fix from v1). > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org >
