Peter Xu <pet...@redhat.com> wrote: > When accept failed, we should setup errp with the reason. More > importantly, the caller may assume errp be non-NULL when error happens, > and not setting the errp may crash QEMU. > > At the same time, move the trace_qio_channel_socket_accept_fail() after > the if check on EINTR. Two reasons: > > 1. when EINTR happened, it's not really a fault (we should just try > again), so we should not log with an "accept failure". > > 2. trace_*() functions may overwrite errno, then the old errno will be > missing. We need to either check errno before trace_*() calls, or > reserve the errno. > > Signed-off-by: Peter Xu <pet...@redhat.com>
Reviewed-by: Juan Quintela <quint...@redhat.com>
