On 5 August 2017 at 02:06, Edgar E. Iglesias <edgar.igles...@gmail.com> wrote: > On Fri, Aug 04, 2017 at 06:20:43PM +0100, Peter Maydell wrote: >> @@ -85,8 +85,10 @@ struct TranslationBlock; >> * @has_work: Callback for checking if there is work to do. >> * @do_interrupt: Callback for interrupt handling. >> * @do_unassigned_access: Callback for unassigned access handling. >> + * (this is deprecated: new targets should use do_transaction_failed >> instead) >> * @do_unaligned_access: Callback for unaligned access handling, if >> * the target defines #ALIGNED_ONLY. >> + * @do_transaction_failed: Callback for handling failed memory transactions > > Looks OK but I wonder if there you might want to clarify that this is a > bus/slave failure and not a failure within the CPU (e.g not an MMU fault).
Yes, we could add "(ie bus faults or external aborts; not MMU faults)" just to clarify. thanks -- PMM
