Dr. David Alan Gilbert <dgilb...@redhat.com> writes: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 1 August 2017 at 17:17, Paolo Bonzini <pbonz...@redhat.com> wrote: >> > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> >> > >> > This code has an optimised, word aligned version, and a boring >> > unaligned version. Recently 084140bd498909 fixed a missing offset >> > addition from the core of both versions. However, the offset isn't >> > necessarily aligned and thus the choice between the two versions >> > needs fixing up to also include the offset. >> > >> > Symptom: >> > A few stuck unsent pages during migration; not normally noticed >> > unless under very low bandwidth in which case the migration may get >> > stuck never ending and never performing a 2nd sync; noticed by >> > a hanging postcopy-test on a very heavily loaded system. >> > >> > Fixes: 084140bd498909 >> > >> > Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com> >> > Reported-by: Alex Benneé <alex.be...@linaro.org> >> > Tested-by: Alex Benneé <alex.be...@linaro.org> >> > >> > -- >> > v2 >> > Move 'page' inside the if (Comment from Paolo) >> > Message-Id: <20170724165125.29887-1-dgilb...@redhat.com> >> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> >> >> Something somewhere along the line seems to have mangled the >> unicode characters in Alex's name :-( >> Also, Alex's email address is typoed, and what should be the >> '---' marker has been written as '--' so the below-the-fold waffle >> is still hanging around in the commit. >> >> This doesn't seem worth rejecting the pull request on the >> eve of rc1 for, but it's still a bit sad :-( > > Hmm yes, I think some of that's mine - the missing 'n' is certainly > my fault; and I may have got his two 'e's in the wrong order, > but I don't know what changed the encoding, that seems right on: > https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07417.html
Hmm also the acute accent should be on the second (not third) e ;-) -- Alex Bennée (breaking UTF-8 workflow since before it was cool)