On 11/20/10 18:22, Andreas Färber wrote: > Am 19.11.2010 um 17:30 schrieb jes.soren...@redhat.com: > >> From: Jes Sorensen <jes.soren...@redhat.com> >> >> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> >> --- >> Makefile | 2 +- >> Makefile.objs | 12 ++++++++++-- >> 2 files changed, 11 insertions(+), 3 deletions(-) > > Tested-by: Andreas Färber <andreas.faer...@web.de> > > Looks good to me and a clean build works okay. > > Any plans for a way to disable NBD build completely? There are warnings > about use of daemon() on Mac OS X and possibly Solaris, and there's > little point in building qemu-nbd if one does not use it.
I think it would be worth adding as an option, however letting it default to 'on' to make sure it gets at least build tested unless a user explicitly disables it. Cheers, Jes
