On Mon, Aug 07, 2017 at 04:46:00PM +0200, Markus Armbruster wrote: > Byte offsets should use QAPI type 'size' (uint64_t). > QCryptoBlockInfoLUKS member @payload-offset and > QCryptoBlockInfoLUKSSlot member @key-offset are 'int' (int64_t). > qcrypto_block_luks_get_info() gets the former QCryptoBlock member > @payload_offset, implicitly converting from uint64_t, and computes the > latter from QCryptoBlockLUKSKeySlot member @key_offset, implicitly > converting from long long. > > Change both offsets to 'size'. > > query-block and query-named-block-nodes now report @payload-offset > values above 2^63-1 correctly instead of their (negative) two's > complement. Should never occur in practice. > > Signed-off-by: Markus Armbruster <arm...@redhat.com>
Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|