Just back from the signed-vs-unsigned swamp, still catching up, sorry for the delay...
Eric Blake <ebl...@redhat.com> writes: > On 07/26/2017 07:09 AM, no-re...@patchew.org wrote: >> Hi, >> >> This series failed build test on s390x host. Please find the details below. >> >> Message-id: 20170726115637.21558-1-kra...@redhat.com >> Subject: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10 >> Type: series >> > >> GEN docs/interop/qemu-ga-qapi.texi >> GEN qga/qapi-generated/qga-qapi-visit.h >> GEN qga/qapi-generated/qga-qmp-commands.h >> GEN qga/qapi-generated/qga-qapi-types.h >> GEN qga/qapi-generated/qga-qapi-types.c >> GEN qga/qapi-generated/qga-qapi-visit.c >> GEN qga/qapi-generated/qga-qmp-marshal.c >> Traceback (most recent call last): >> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line >> 300, in <module> >> main(sys.argv) >> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line >> 296, in main >> print texi_schema(schema) >> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line >> 279, in texi_schema >> gen.symbol(doc, schema.lookup_entity(doc.symbol)) >> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line >> 263, in symbol >> entity.visit(self) >> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi.py", line >> 1137, in visit >> self.member_names(), self.prefix) >> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line >> 218, in visit_enum_type >> member_func=texi_enum_value)) >> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line >> 200, in texi_entity >> + texi_sections(doc)) >> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line >> 160, in texi_members >> items += member_func(section.member) + desc + '\n' >> File "/var/tmp/patchew-tester-tmp-xs4657r8/src/scripts/qapi2texi.py", line >> 133, in texi_enum_value >> return '@item @code{%s}\n' % value.name >> AttributeError: 'NoneType' object has no attribute 'name' > > Eww, we have a bug in our qapi generator (a stack dump instead of a nice > error message). I suspect this is caused by your use of '@ac_*' instead > of spelling out all the ac_ members added in qapi-schema.json in 4/5 - Yes, we require doc comments to match the schema. Wildcards aren't supported. They could be, if we want them badly enough. > but it IS something that needs to be fixed on your end to quit tripping > up the doc generator. Has anyone worked on a fix for qapi2texi.py?