On 08/09/2017 10:57 AM, Vladimir Sementsov-Ogievskiy wrote: >>>> This is because quite happens before first mirror request is done >>> s/quite/quit/ >>> >>>> (and, in specified case, even before block-job len field is set). >>>> To prevent it let's just add a sleep for 0.3 seconds before quite. >> Here, as well. >> >> Maybe: >> >> This is because, under heavy load, the quit can happen before the first >> iteration of the mirror request has occurred. To make sure we've had >> time to iterate, let's just add a sleep for 0.3 seconds before quitting. >> >> >>>> "return" >>>> +# If we don't sleep here 'quit' command may be handled before >>>> +# the first mirror iteration is done >>>> +sleep 0.5 >> The commit message disagrees with the code (.3 vs. .5) - which one is >> correct? >> > Let it be .5, as I've tested it.
With a correct commit message (maintainer can touch it up), Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
