On 08/10/2017 11:04 AM, Daniel P. Berrange wrote: > The inet_parse() function looks for 'ipv4' and 'ipv6' > flags, but only treats them as bare bool flags. The normal > QemuOpts parsing would allow on/off values to be set too. > > This updated inet_parse() so that its handling of the
s/updated/updates/ ?
> 'ipv4' and 'ipv6' flags matches that done by QemuOpts.
Do we have a regression compared to any previous version, such that this
patch might be considered 2.10 material? Offhand, though, I think it's
fine as the end of your series, waiting for 2.11.
>
> Signed-off-by: Daniel P. Berrange <berra...@redhat.com>
> ---
> tests/test-sockets-proto.c | 13 -------------
> util/qemu-sockets.c | 36 ++++++++++++++++++++++++++++++++----
> 2 files changed, 32 insertions(+), 17 deletions(-)
>
> +++ b/util/qemu-sockets.c
> @@ -616,6 +616,25 @@ err:
> }
>
> /* compatibility wrapper */
> +static int inet_parse_flag(const char *flagname, const char *optstr, bool
> *val,
> + Error **errp)
> +{
> + char *end;
> + size_t len;
> +
> + end = strstr(optstr, ",");
Do we need to check that we are not landing on a ',,' escape that would
make QemuOpts behave differently? [That is, ipv4=on,,garbage should be
parsed as setting ipv4 to 'on,garbage' (which is not valid), and NOT
setting 'ipv4=on' followed by the 'garbage' or ',garbage' key - while
the key named 'garbage' would fail, there might be other key names where
the distinction matters for catching command line typos]
But if this is unrelated to QemuOpts escape parsing, it seems okay.
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
