On Thu, Aug 10, 2017 at 02:02:32PM -0500, Eric Blake wrote:
> On 08/10/2017 10:55 AM, Daniel P. Berrange wrote:
> > Now that keycode numbers are converted to QKeyCodes immediately
> > when creating input events, the InputKeyEvent struct can be
> > changed to only accept a QKeyCode, instead of a KeyValue.
> >
> > Signed-off-by: Daniel P. Berrange <berra...@redhat.com>
> > ---
>
> > +++ b/qapi-schema.json
> > @@ -5747,7 +5747,7 @@
> > # Since: 2.0
> > ##
> > { 'struct' : 'InputKeyEvent',
> > - 'data' : { 'key' : 'KeyValue',
> > + 'data' : { 'key' : 'QKeyCode',
> > 'down' : 'bool' } }
>
> Isn't this going to break backwards-compatibility of 'input-send-event'?
>
> I think you have to keep the public API the same, even if you make the
> conversion as early as possible to the preferred mapping form internally.
Oh urgh, I never noticed there even was an "input-send-event" command,
only "send-key".
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
