On Fri, Aug 18, 2017 at 05:00:18PM +0100, Anthony PERARD wrote: > > > > > > > > > > Clean it up after 2.10. > > > > > > > > > > > So is the v2 good enough or do I need to resend it? > > Do you really need it in 2.10? > > it's only 2 days left till release so unless it's blocker > > I'd wait till after release and do clean fix. > > It mostly means that someone building QEMU 2.10 would be unable to do > PCI passthrough hotplug. But PCI PT works fine when the device is added > before a guest is started. Maybe hotplug can work as well with extra > steps done in the guest to force to probe for new devices. > > So I would say it is not a blocker, and could be added in the known > issue of the release notes?
Regressions aren't nice. But risk to working setups isn't nice either. If you can come up with a patch that obviously limits the effect to xen only, I'll merge it or ack for merge through Xen tree. > -- > Anthony PERARD