Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20170821141008.19383-1-f...@redhat.com
Subject: [Qemu-devel] [PATCH v4 0/4] scsi-block: Support werror/rerror
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
2c3500c6c6 scsi-block: Support rerror/werror
05189062ee scsi: Introduce scsi_sense_buf_to_errno
71fe29752d scsi: Improve scsi_sense_to_errno
e0bc108941 scsi: Refactor scsi sense interpreting code
=== OUTPUT BEGIN ===
Checking PATCH 1/4: scsi: Refactor scsi sense interpreting code...
ERROR: space prohibited after that '-' (ctx:WxW)
#84: FILE: block/iscsi.c:213:
+ return - scsi_sense_to_errno(sense->key,
^
ERROR: return of an errno should typically be -ve (return -EBUSY)
#151: FILE: util/scsi.c:22:
+ return EBUSY;
ERROR: return of an errno should typically be -ve (return -EACCES)
#153: FILE: util/scsi.c:24:
+ return EACCES;
ERROR: return of an errno should typically be -ve (return -ECANCELED)
#155: FILE: util/scsi.c:26:
+ return ECANCELED;
ERROR: return of an errno should typically be -ve (return -EIO)
#160: FILE: util/scsi.c:31:
+ return EIO;
ERROR: return of an errno should typically be -ve (return -EINVAL)
#167: FILE: util/scsi.c:38:
+ return EINVAL;
ERROR: return of an errno should typically be -ve (return -ENOSPC)
#169: FILE: util/scsi.c:40:
+ return ENOSPC;
ERROR: return of an errno should typically be -ve (return -ENOTSUP)
#171: FILE: util/scsi.c:42:
+ return ENOTSUP;
ERROR: return of an errno should typically be -ve (return -ENOMEDIUM)
#175: FILE: util/scsi.c:46:
+ return ENOMEDIUM;
ERROR: return of an errno should typically be -ve (return -EACCES)
#177: FILE: util/scsi.c:48:
+ return EACCES;
ERROR: return of an errno should typically be -ve (return -EIO)
#179: FILE: util/scsi.c:50:
+ return EIO;
total: 11 errors, 0 warnings, 141 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/4: scsi: Improve scsi_sense_to_errno...
ERROR: return of an errno should typically be -ve (return -EAGAIN)
#49: FILE: util/scsi.c:54:
+ return EAGAIN;
ERROR: return of an errno should typically be -ve (return -ENOTCONN)
#51: FILE: util/scsi.c:56:
+ return ENOTCONN;
total: 2 errors, 0 warnings, 37 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/4: scsi: Introduce scsi_sense_buf_to_errno...
ERROR: return of an errno should typically be -ve (return -EIO)
#36: FILE: util/scsi.c:66:
+ return EIO;
ERROR: return of an errno should typically be -ve (return -EIO)
#41: FILE: util/scsi.c:71:
+ return EIO;
ERROR: return of an errno should typically be -ve (return -EIO)
#49: FILE: util/scsi.c:79:
+ return EIO;
ERROR: return of an errno should typically be -ve (return -EIO)
#56: FILE: util/scsi.c:86:
+ return EIO;
total: 4 errors, 0 warnings, 39 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/4: scsi-block: Support rerror/werror...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
