On 08/24/2017 10:33 AM, Stefan Hajnoczi wrote: > See Patch 1 for the segfault fix. Patches 2 & 3 add qemu-iotests coverage. > > This is a rare crash that we'll probably only see in testing. It only seems > to > happen with UNIX domain sockets.
Rare enough that I don't think it is 2.10-rc4 material. I'll review, and if I don't find anything needing a respin, I'll add it to my NBD queue for 2.11. > > Stefan Hajnoczi (3): > nbd-client: enter read_reply_co during init to avoid crash > qemu-iotests: improve nbd-fault-injector.py startup protocol > qemu-iotests: test NBD over UNIX domain sockets in 083 > > block/nbd-client.c | 2 +- > tests/qemu-iotests/083 | 138 ++++++++++++++++++----------- > tests/qemu-iotests/083.out | 145 > +++++++++++++++++++++++++++---- > tests/qemu-iotests/common.filter | 4 +- > tests/qemu-iotests/nbd-fault-injector.py | 4 + > 5 files changed, 220 insertions(+), 73 deletions(-) > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
